Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picked #5286 #5287

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Cherry picked #5286 #5287

merged 1 commit into from
Dec 18, 2024

Conversation

neacsu
Copy link
Contributor

@neacsu neacsu commented Dec 18, 2024

This change is Reviewable

@neacsu neacsu added this to the Reeses milestone Dec 18, 2024
@neacsu neacsu merged commit f7a7a80 into release/2024.15-reeses Dec 18, 2024
18 of 20 checks passed
@neacsu neacsu deleted the feature/mix_tun_const branch December 18, 2024 14:23
@tommyv1987
Copy link
Contributor

tommyv1987 commented Jan 8, 2025

Testing Completion Report: Feature/Mix_Tun_Const

Testing Completion Date: 08/01/2025


Testing Steps Performed:

  1. Review File: common/network-defaults/src/constants.rs

    • Confirmed updated mixnet_vpn constants were added.
  2. Review File: service-providers/ip-packet-router/src/constants.rs

    • Checked replacement of legacy TUN_* constants with new mixnet_vpn constants.
    • Validated alignment of routing traffic configurations.
  3. Review File: service-providers/ip-packet-router/src/ip_packet_router.rs

    • Ensured new nym_network_defaults::constants::mixnet_vpn constants replaced old references.
    • Verified TunDeviceConfig consistency.
  4. Review File: service-providers/ip-packet-router/src/util/generate_new_ip.rs

    • Confirmed substitution of TUN_DEVICE_* constants with NYM_TUN_DEVICE_* constants.
    • Tested functionality for generating random IPs within subnet.

Validation:

  • Test Passed
  • Issues Found (Please specify below)

Attachments (if applicable):

N/A


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants