Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update indexed_db_futures #5347

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Jan 14, 2025

updates the indexed_db_futures dependency to stop relying on the fork.

there's been a lot of changes in the API so before it could be merged, I'd need to first create a dummy JS project to double check the behaviour still works, in particular get_all_keys since now we're returning Vec<JsValue> rather than js_sys::Array and I have no idea whether JS itself won't freak out because of it (since the list allocation would be in rust instead of js)


This change is Reviewable

@jstuczyn jstuczyn added this to the Hu milestone Jan 14, 2025
@jstuczyn jstuczyn force-pushed the chore/indexed-db-futures-update branch from fca7117 to 7c46410 Compare January 14, 2025 13:58
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 5:23pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 5:23pm

@jstuczyn jstuczyn force-pushed the chore/indexed-db-futures-update branch from b295054 to e50f152 Compare January 15, 2025 17:23
@jstuczyn jstuczyn merged commit 61a4433 into develop Jan 16, 2025
19 of 20 checks passed
@jstuczyn jstuczyn deleted the chore/indexed-db-futures-update branch January 16, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant