Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send shutdown instead of panic when reaching max fail #5398

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

octol
Copy link
Contributor

@octol octol commented Jan 29, 2025

Remove a panic and an unwrap inside client-core that is hit occasionally in the vpn client

This is a change that can have wide ranging impact since it changes the task handling and it's inside client-core, which is used in many components and services, so preventing regressions is important

This change is Reviewable

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 11:31am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2025 11:31am

@octol octol marked this pull request as ready for review January 29, 2025 11:30
@octol octol requested a review from jstuczyn January 29, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant