Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing blueprint and moving dependencies to npm #41

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

gmurphey
Copy link
Contributor

@gmurphey gmurphey commented Jun 23, 2017

With ember-cli moving away from bower dependencies, thought it would be beneficial to move ember-hifi's dependencies over to npm.

@gmurphey gmurphey force-pushed the npm-dependencies branch 2 times, most recently from baf1396 to 7c7d38c Compare June 24, 2017 21:40
@noslouch
Copy link
Contributor

noslouch commented Jun 26, 2017

This looks great, but I'd like for it to run on circle before we merge. I just updated our settings so that forks can run in our build system; would you mind adding a new commit and pushing again in order to kick off a build?

I think an update to the readme to take out the generator command should do the trick ;)

@gmurphey
Copy link
Contributor Author

gmurphey commented Jun 26, 2017

I just realized that app.import can't use node_modules paths. I'll update this to build a vendor tree.

@gmurphey gmurphey force-pushed the npm-dependencies branch 3 times, most recently from 7c0d336 to 3157f72 Compare June 26, 2017 18:38
@gmurphey
Copy link
Contributor Author

I'm not sure what the node-sass errors are about, but I see them on a clean master run of yarn test as well. Will try to dig into this later.

@gmurphey
Copy link
Contributor Author

So I think I've narrowed these failures down to an issue with yarn removing node-sass artifacts after some of the ember-try scenarios (yarnpkg/yarn#3506). I was able to reproduce locally, and it seems, from my limited testing, that this is fixed in yarn 0.27 (pre-release, atm). I'm not sure if it's possible to have circleci use a specific version of yarn. If not, I'd be happy to submit a PR that has circleci use npm (which doesn't face this issue) until circleci is updated.

@noslouch
Copy link
Contributor

noslouch commented Jun 26, 2017 via email

@@ -59,9 +59,13 @@
"web"
],
"dependencies": {
"broccoli-funnel": "^1.2.0",
"broccoli-merge-trees": "^1.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these go into devDependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consuming apps will need these to build the addon's vendor tree. If they're in devDependencies, they won't be available to the app at build-time.

@noslouch
Copy link
Contributor

I added a command to our circle config that uses that yarn pre release and everything's looking green!

One thing: I'm not 💯 on how dependencies vs devDependencies affects upstream apps, so I'm curious if those broccoli deps would affect app builds.

let me know your thoughts on that question and I'll merge 'n' release.

@noslouch noslouch merged commit 5e2c0ac into nypublicradio:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants