GOTH-489 Author bylines wrong when reloading page after publishing new story #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://mwalshgoth-489-68ftm.squash.io |
walsh9
force-pushed
the
mwalsh/GOTH-489
branch
from
52906e8
to
04f9d34
Compare
kimlarocca
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a weird one. Not sure why data appears to be persisting in nuxt across reloads or how author data is getting assigned to the wrong stories, but the issues appear to have something to do with nuxt's payload caching. The closest thing to documentation I can find for this feature appears here: nuxt/framework#3985
setting
initalCachetofalsewith useFetch appears to solve the problem. Not sure if this will cause a noticable performance hit or extra traffic but I don't expect it to be an issue.Note: This flag has been removed in the 3.0 release and the way the caching works has change, so updating to stable may also just fix our issues, but for now this seems to work. When we update we should try to remember to remove this flag from our requests though, since it does nothing in nuxt 3.0.
nuxt/framework#8885