errors when trying to build with SPM

[mr-fixit]

@cassianodialpad reported errors when trying to build with SPM

#342 (comment)

i took a stab at fixing, see branch bug/fix-build-error haven't figured it out.

[cassianodialpad]

@mr-fixit I got a different error from branch bug/fix-build-error

In file included from /Users/cassiano/Library/Developer/Xcode/DerivedData/Dialpad-dcrsnbdqvqefaudlnsocmkwonmef/SourcePackages/checkouts/NYTPhotoViewer/NYTPhotoViewerGIF/NYTPhotosViewController.m:15:
/Users/cassiano/Library/Developer/Xcode/DerivedData/Dialpad-dcrsnbdqvqefaudlnsocmkwonmef/SourcePackages/checkouts/NYTPhotoViewer/NYTPhotoViewerGIF/include/NYTScalingImageView.h:27:33: error: unknown type name 'PINAnimatedImageView'; did you mean 'PINAnimatedImage'?
@property (nonatomic, readonly) PINAnimatedImageView *imageView;
                                ^~~~~~~~~~~~~~~~~~~~
                                PINAnimatedImage
In module 'PINRemoteImage' imported from /Users/cassiano/Library/Developer/Xcode/DerivedData/Dialpad-dcrsnbdqvqefaudlnsocmkwonmef/SourcePackages/checkouts/NYTPhotoViewer/NYTPhotoViewerGIF/include/NYTScalingImageView.h:13:
/Users/cassiano/Library/Developer/Xcode/DerivedData/Dialpad-dcrsnbdqvqefaudlnsocmkwonmef/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINAnimatedImage.h:67:12: note: 'PINAnimatedImage' declared here
@interface PINAnimatedImage : NSObject
           ^
/Users/cassiano/Library/Developer/Xcode/DerivedData/Dialpad-dcrsnbdqvqefaudlnsocmkwonmef/SourcePackages/checkouts/NYTPhotoViewer/NYTPhotoViewerGIF/NYTPhotosViewController.m:133:20: warning: incompatible pointer types assigning to 'UIView *' from 'PINAnimatedImage *' [-Wincompatible-pointer-types]
        endingView = self.currentPhotoViewController.scalingImageView.imageView;
                   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/cassiano/Library/Developer/Xcode/DerivedData/Dialpad-dcrsnbdqvqefaudlnsocmkwonmef/SourcePackages/checkouts/NYTPhotoViewer/NYTPhotoViewerGIF/NYTPhotosViewController.m:429:22: warning: incompatible pointer types assigning to 'UIView *' from 'PINAnimatedImage *' [-Wincompatible-pointer-types]
        startingView = self.currentPhotoViewController.scalingImageView.imageView;
                     ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/Users/cassiano/Library/Developer/Xcode/DerivedData/Dialpad-dcrsnbdqvqefaudlnsocmkwonmef/SourcePackages/checkouts/NYTPhotoViewer/NYTPhotoViewerGIF/include/NYTScalingImageView.h:27:33: Unknown type name 'PINAnimatedImageView'; did you mean 'PINAnimatedImage'?

[cassianodialpad]

Bump! Any ideas on this?

[cassianodialpad]

@mr-fixit Hi! Any ideas on this?

[mr-fixit]

i'm back to looking at this... no clues so far.

[mr-fixit]

i think this was fixed by pinterest/PINRemoteImage@93428e8
merged may 18, 2021
as yet unreleased

[Xendrez]

Also can't use a previous version because the Package file doesn't have manifests for previous versions

[mr-fixit]

I think SPM packaging of NYTPhotoViewer is going to be broken until PINRemoteImage can release a new version.

Requested here: pinterest/PINRemoteImage#624

[mr-fixit]

Also can't use a previous version because the Package file doesn't have manifests for previous versions

Sorry, I don't know what you're saying here.

Is 'the Package file' a) package files in general, b) NYTPhotoViewer's, or c) PINRemoteImage's?

Is 'the previous version' a) NYTPhotoViewer's, or b) PINRemoteImage's?

[PranotiK523]

Hi, I'm currently noticing similar errors when i try to bump up the version to 5.0.8 via SPM, my project is using 5.0.6 as of today.

Any ideas here, since this is avoiding us to use the latest version?

[mr-fixit]

One idea is to use NYTPhotoViewer via CocoaPods.

[PranotiK523]

Unfortunately we only rely on SPM as of today.

[mr-fixit]

I hear you. Put pressure on PINRemoteImage to fix #624.

[PranotiK523]

Thanks @mr-fixit I will probably do that now.