Fix #341 - restore support for animated gifs

[mr-fixit]

Added 2nd Target

(avoiding the '[target 2] has source overlapping sources' problem with a symlink)

    targets: [
        .target(
            name: "NYTPhotoViewer",
            path: "NYTPhotoViewer"
        ),
        .target(
            name: "NYTPhotoViewerGIF",
            dependencies: ["PINRemoteImage"],
            path: "SourceSymLink",
            cSettings: [
              .define("ANIMATED_GIF_SUPPORT", to: "1")
            ]
        )
    ]

Tweaked imports in 3 files by changing

#import <PINRemoteImage/FOO.h>

to

#if SWIFT_PACKAGE
  #import "FOO.h"
#else
  #import <PINRemoteImage/FOO.h>
#endif

[mr-fixit]

I claim this fixes issue #341

[cassianodialpad]

@ZevEisenberg If you could please review this PR, it would be much appreciated! 😊

[cassianodialpad]

Bump! This would be very much appreciated! 😄

[ZevEisenberg]

Sorry I dragged my feet so long on this. I thought I'd have to do a bunch of testing or something, but if this is working for people who need it to work, I'm happy with it!

[mr-fixit]

@cassianodialpad, please let me know if i need to do something more to 'ship' this and make it accessible to you.

[ZevEisenberg]

Probably need a new CocoaPods release to make it official

[mr-fixit]

even though this is "just" an SPM thing?

[ZevEisenberg]

Oh, good point

[cassianodialpad]

@mr-fixit I'm getting these errors on trying to build with SPM from the merge commit 0bdc8d3 :

SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:97:24: Receiver 'PINAnimatedImageView' for class message is a forward declaration
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:97:23: Receiver type 'PINAnimatedImageView' for instance message is a forward declaration
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:126:20: Property 'transform' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:127:20: Property 'image' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:131:20: Property 'animatedImage' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:134:20: Property 'frame' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:152:24: Property 'animatedImage' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:152:56: Property 'image' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:153:43: Property 'animatedImage' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:153:74: Property 'animatedImage' cannot be found in forward class object 'PINAnimatedImageView'
SourcePackages/checkouts/NYTPhotoViewer/SourceSymLink/NYTScalingImageView.m:153:110: Property 'image' cannot be found in forward class object 'PINAnimatedImageView'

[mr-fixit]

are you sure you have the right commit? the merge commit from this morning is a4c0b51

[cassianodialpad]

@mr-fixit Sorry, copy/paste issue... Yes, I tried commit a4c0b51 and got those errors on a clean build.

[mr-fixit]

i didn't get the errors at first, but do now. looking into it. thanks for reporting!

[mr-fixit]

i made #344