Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup from dismissal PR #121 #122

Merged
merged 5 commits into from
Jan 13, 2016
Merged

Followup from dismissal PR #121 #122

merged 5 commits into from
Jan 13, 2016

Commits on Jan 13, 2016

  1. [minor] change space/braces style to adhere to style guide

    @cdzombak
    cdzombak committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    49d54ba View commit details
    Browse the repository at this point in the history

  2. [minor] change name of animation flag

    @cdzombak
    cdzombak committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    75b1fdb View commit details
    Browse the repository at this point in the history

  3. Run user-supplied completion block on dismissing PhotosVC

    @cdzombak
    cdzombak committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    79d3594 View commit details
    Browse the repository at this point in the history

  4. Don’t call delegate methods for non-interactive dismissals 

    This seems to align with Cocoa convention but I will accept debate on this choice.
    @cdzombak
    cdzombak committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    e5b3144 View commit details
    Browse the repository at this point in the history

  5. Move overlay dismissal logic to dismissViewController:… 

    Now that all dismissals go through this method, this seems like the
right place to manage overlay view visibility.
    @cdzombak
    cdzombak committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    c17b7f7 View commit details
    Browse the repository at this point in the history