Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Drone Cloud to Actions #85

Merged
merged 8 commits into from
Feb 8, 2023
Merged

Conversation

prathameshnyt
Copy link
Contributor

@prathameshnyt prathameshnyt commented Feb 3, 2023

Migrating from Drone Cloud to Actions.
DOCKERHUB credentials are associated with nytoss account.
SLACK_WEBHOOK_URL is currently configured to post messages on #dv-notifications channel.

@dgrizzanti
Copy link

We should remove the .drone.yml as part of the PR, otherwise both Actions and Drone will try and build/push the image when this is merged.

@prathameshnyt
Copy link
Contributor Author

@tonglil @montmanu can you please check this pull request and let us know in case any changes are required?

Thanks,
Prathamesh

"text": "GitHub Actions Build Result: ${{ job.status }}\n triggered_by: ${{ github.actor }}\n job url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}\n commit url: ${{ github.event.head_commit.url }}"
}
env:
# webhook for posting on #dv-notifications for now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at drone-gke, that one says it's posting to dv-cdp-alerts.

Could you confirm because I don't see notifications in either channel from GHA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the slack channel, we have not finalized it yet for DV. for the gae repo I am posting on #dv-notifications if the event is not a pull request. also, now this url will be channel specific with the new slack incoming webhook app for the respective teams.

.github/workflows/github-actions-workflow.yaml Outdated Show resolved Hide resolved
@prathameshnyt
Copy link
Contributor Author

@montmanu can you please check again when you get a chance?

Copy link

@montmanu montmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prathameshnyt
Copy link
Contributor Author

@dgrizzanti @grantmiillernyt as discussed added a login skip step for the pull request event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants