-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Drone Cloud to Actions #85
Conversation
We should remove the |
"text": "GitHub Actions Build Result: ${{ job.status }}\n triggered_by: ${{ github.actor }}\n job url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}\n commit url: ${{ github.event.head_commit.url }}" | ||
} | ||
env: | ||
# webhook for posting on #dv-notifications for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at drone-gke, that one says it's posting to dv-cdp-alerts
.
Could you confirm because I don't see notifications in either channel from GHA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the slack channel, we have not finalized it yet for DV. for the gae repo I am posting on #dv-notifications if the event is not a pull request. also, now this url will be channel specific with the new slack incoming webhook app for the respective teams.
@montmanu can you please check again when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@dgrizzanti @grantmiillernyt as discussed added a login skip step for the pull request event. |
Migrating from Drone Cloud to Actions.
DOCKERHUB credentials are associated with
nytoss
account.SLACK_WEBHOOK_URL
is currently configured to post messages on#dv-notifications
channel.