Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipping templates for Drone 1.x #132

Merged
merged 12 commits into from
Apr 28, 2020
Merged

Fix skipping templates for Drone 1.x #132

merged 12 commits into from
Apr 28, 2020

Conversation

tonglil
Copy link
Member

@tonglil tonglil commented Apr 25, 2020

Drone 1.x (tested in 1.7) drops environment variables whose value is an empty string "", eg PLUGIN_VAR="" is removed from the environment.

In order to remove dependency on how Drone exposes environment variables, this stops using the "" sentinel value to determine skipping processing a template or secret_template file.

Instead explicit configuration is required to skip processing those files if they exist in the working directory:

  • skip_template: bool
  • skip_secret_template: bool

Copy link
Member

@mlclmj mlclmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome--thanks!

Copy link

@Emmawaterman Emmawaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@tonglil tonglil merged commit c8a8687 into master Apr 28, 2020
@tonglil tonglil deleted the log-skipping branch April 28, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants