Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dry-run to dry-run=client #143

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Update dry-run to dry-run=client #143

merged 2 commits into from
Apr 1, 2021

Conversation

tonglil
Copy link
Member

@tonglil tonglil commented Apr 1, 2021

Migrate to --dry-run=client.

W0401 00:09:10.499551      90 helpers.go:535] --dry-run is deprecated and can be replaced with --dry-run=client.

@tonglil tonglil requested a review from a team as a code owner April 1, 2021 00:37
mlclmj
mlclmj approved these changes Apr 1, 2021
View reviewed changes
Copy link
Member

@mlclmj mlclmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tonglil tonglil merged commit a8b78aa into master Apr 1, 2021
@tonglil tonglil deleted the update-dry-run branch April 1, 2021 21:00
@hs1o
Copy link

hs1o commented Apr 6, 2021

This merged will broken when kubectl >= 1.18, --dry-run should be --dry-run=true
Please see [[link]].

mlclmj added a commit that referenced this pull request Apr 6, 2021
@mlclmj
Revert "Update dry-run to dry-run=client (#143)"
e260844 
This reverts commit a8b78aa.
@tonglil
Copy link
Member Author

tonglil commented Apr 6, 2021 •
edited
Loading

Thanks for raising @jetthaisean.
We plan on making a fix.

  1. Check the version and use --dry-run=client for 1.18 or higher, otherwise --dry-run=true (https://v1-18.docs.kubernetes.io/docs/setup/release/notes/#kubectl-1)
  2. Roll back this change back until --dry-run=true is removed from kubectl

@mlclmj mlclmj mentioned this pull request Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msuterski msuterski msuterski approved these changes

@prune998 prune998 prune998 approved these changes

@mlclmj mlclmj mlclmj approved these changes

@prathameshnyt prathameshnyt Awaiting requested review from prathameshnyt

@swardlincoln swardlincoln Awaiting requested review from swardlincoln

@karinanguyen karinanguyen Awaiting requested review from karinanguyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tonglil @hs1o @msuterski @prune998 @mlclmj