Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DV-12285: add create-namespace parameter #155

Merged
merged 2 commits into from
Apr 29, 2022
Merged

DV-12285: add create-namespace parameter #155

merged 2 commits into from
Apr 29, 2022

Conversation

montmanu
Copy link
Contributor

By default, if a user specifies a value for the namespace parameter, the plugin automatically applies a hard-coded namespace resource to the cluster (presumably to ensure that the namespace exists before it attempts to apply any other resources to it).

This change provides users a way to opt-out of that auto create/apply functionality. The create-namespace parameter value defaults to true, which reflects the current implementation. To opt-out of that default functionality, users can now set that parameter to false.

@montmanu montmanu requested a review from a team as a code owner April 28, 2022 22:17
@@ -120,6 +120,30 @@ pipeline:
# ...
```

### `namespace`
Copy link
Contributor Author

@montmanu montmanu Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this parameter value already existed, but it was undocumented

@montmanu montmanu merged commit baf4df6 into main Apr 29, 2022
@montmanu montmanu deleted the dv-12285 branch April 29, 2022 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants