Add option to wait for job completion or timeout #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgrunwald
requested review from
lukepatrick,
imdaisyadams and
cjohnson-nytimes
mattgrunwald
changed the title
anujdogra-nyt
approved these changes
Mar 10, 2023
tonglil
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is a change to the core functionality, did you make a corresponding PR to drone-eks?
Did you update the tests?
Did you update the docs?
The cooking CMS drone pipeline would like to have separate CI/CD steps for applying a
Jobto run database migrations and for applying all other resources (Deployments,ServiceAccounts, etc.). This PR adds functionality to wait for one or moreJobs to complete (including an optional timeout).This PR mirrors the changes in the
drone-eksPR here.