Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for performing server-side applies #191

Merged
merged 8 commits into from
May 17, 2023
Merged

Add support for performing server-side applies #191

merged 8 commits into from
May 17, 2023

Conversation

KiaFarhang
Copy link
Contributor

@KiaFarhang KiaFarhang commented May 11, 2023 •
edited
Loading

Closes #190 with a new flag to perform server-side applies.

If this is a change to the core functionality, did you make a corresponding PR to drone-eks?

  • yes
  • no
  • n/a

Did you update the tests?

  • yes
  • no
  • n/a

Did you update the docs?

  • yes
  • no
  • n/a

@KiaFarhang KiaFarhang requested a review from a team as a code owner May 11, 2023 21:10
montmanu
montmanu approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@montmanu montmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that question on the interaction between server-side + dry-run, lgtm!

main.go Outdated Show resolved Hide resolved
@montmanu montmanu merged commit 768788e into nytimes:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montmanu montmanu montmanu approved these changes

@marzagao marzagao Awaiting requested review from marzagao marzagao is a code owner automatically assigned from nytimes/delivery-engineering

@soeirosantos soeirosantos Awaiting requested review from soeirosantos soeirosantos is a code owner automatically assigned from nytimes/delivery-engineering

@viccro viccro Awaiting requested review from viccro viccro is a code owner automatically assigned from nytimes/delivery-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support server-side applies
2 participants
@KiaFarhang @montmanu