-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need pointer to implement CloseNotifier #63
Conversation
You’d be better off changing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! I've got one small style request.
gzip_test.go
Outdated
@@ -325,17 +325,35 @@ func TestFlushBeforeWrite(t *testing.T) { | |||
} | |||
|
|||
func TestImplementCloseNotifier(t *testing.T) { | |||
request := &http.Request{} | |||
request.Header = http.Header{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind using https://golang.org/pkg/net/http/httptest/#NewRequest here instead of building the request and header in 2 lines?
🌭 🍕 thanks!! |
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
This version of gziphandler includes a fix that fixes GzipResponseWriter to implement CloseNotifier nytimes/gziphandler#63
GzipResponseWriterWithCloseNotify doesn't implement CloseNotifier, but *GzipResponseWriterWithCloseNotify does.
Fix the tests to really verify with a request that accept gzip.