Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes loaderUtils.parseQuery() deprecation warning coming from Webpack #472

Closed
wants to merge 6 commits into from
Closed

Conversation

janhoogeveen
Copy link
Contributor

Main issue we're trying to solve here:
#407

Related reading:

Should be a straightforward PR. I've tested the changes locally and there's no more errors in my logs!

@ccpricenytimes
Copy link
Contributor

Hi @janhoogeveen thanks for making these changes! I'd like to include this as part of our next larger release, would you mind moving the changelog into the Master section and reverting the package.json version bump?

@janhoogeveen
Copy link
Contributor Author

Hy @ccpricenytimes, absolutely. Will do it somewhere today.

Jan Hoogeveen added 3 commits May 3, 2017 10:30
* 'master' of github.com:NYTimes/kyt:
  Adds prep for 0.5.5 (#479)
  move react-hot-loader after babel-polyfill (#473)
  fixes history api for static starter kyt (#468)
  Adds .ico to file stub (#475)
* 'master' of github.com:janhoogeveen/kyt:
@janhoogeveen
Copy link
Contributor Author

@ccpricenytimes All should be ok now, it's up to date with upstream and the only 2 changes are the version bumps for babel-loader and css-loader.

@delambo
Copy link
Member

delambo commented May 24, 2017

@janhoogeveen sorry to get to this so late! I suspect that merging is blocked because the yarn files have conflicts. Instead of making you do more work to update this PR, I think I'm going to close this in favor of #482 which updates webpack and the loaders. Then we'll get all of the babel libraries in a future update, hopefully soon.

🙏

@delambo delambo closed this May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants