Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Previously, character with diacritics dissapear in slug. For example, "Öğretmenelere Öneriler" becomes "retmenelere-neriler". Now, with a change to the regex, slugify is able to use it's built in functionality of transforming diacritics to it's non diacritic counterparts ş -> s, ç -> c etc.
Related Issue
#267
Motivation and Context
Badly written slugs are a big issue for non-english internet and the links are less accessible.
Checklist
npm run lint
and updated code style accordinglynpm run test
passes