Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Altered ivars being accessed directly in init. #16

Merged
merged 2 commits into from
Aug 3, 2013
Merged

Altered ivars being accessed directly in init. #16

merged 2 commits into from
Aug 3, 2013

Conversation

jacobvanorder
Copy link
Contributor

This is in response to Dave Delong's issue.

See here for definitive proof.

Fixes #6

@mbbischoff
Copy link
Contributor

I don't know if we should say init specifically because that leaves out other designated initializers like initWithFrame:. Maybe something like "initializer methods".

@bcapps
Copy link
Contributor

bcapps commented Aug 2, 2013

@jacobvanorder - Could you include that documentation link in the guide itself? Maybe just linking the "initializer methods and dealloc" text would work.

bcapps added a commit that referenced this pull request Aug 3, 2013
Altered ivars being accessed directly in init.
@bcapps bcapps merged commit 4167c09 into nytimes:master Aug 3, 2013
@mbbischoff
Copy link
Contributor

@jacobvanorder Thanks so much for the patch! 👍

@jacobvanorder
Copy link
Contributor Author

@mattbischoff Thanks for opening up the style guide. I'll contribute more if I see anything else.

@mpkeefe
Copy link

mpkeefe commented Aug 3, 2013

We've debated this internally recently, but lacked time to develop a formal proof. Great example of the benefit of opening up the guidelines to a wide audience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ivars should be directly accessed in init'ers
4 participants