feature: Api Server #43
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lexedia
reviewed
Dec 11, 2024
frontend/src/service/axios.ts
Outdated
There was a problem hiding this comment.
Why do we use axios?
fetch is globally available.
Lexedia
reviewed
Dec 14, 2024
frontend/src/service/httpClient.ts
Outdated
| message: string | ||
| } | ||
|
|
||
| export async function request<T extends object>({path, method = 'GET', auth = false}: FetchParams) { |
There was a problem hiding this comment.
Suggested change
| export async function request<T extends object>({path, method = 'GET', auth = false}: FetchParams) { | |
| export async function request<T extends Record<string | number, unknown> | unknown[]>({path, method = 'GET', auth = false}: FetchParams) { |
extends object is certainly not what you want here, with the extends object clause will allow any object, e.g request<string>() is perfectly valid.
| export const discordLoginUri = encodeURI(`https://discord.com/oauth2/authorize?client_id=${process.env.REACT_APP_CLIENT_ID}&response_type=code&redirect_uri=${process.env.REACT_APP_REDIRECT_URL}&scope=identify+guilds`); | ||
|
|
||
| export function getUserAvatar(id: string, hash: string) { | ||
| return `https://media.discordapp.net/avatars/${id}/${hash}.png?size=64`; |
There was a problem hiding this comment.
This should use the cdn, not the media proxy
Lexedia
reviewed
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.