Merge pull request #3 from pnicolli/pnicolli_optimize

Optimized calls to getComputedStyle
nzambello · Sep 10, 2017 · 21ec527 · 21ec527
2 parents 82d5156 + d43e234
commit 21ec527
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/ellipsed.js b/lib/ellipsed.js
@@ -38,7 +38,8 @@ function ellipsed() {
       var textBeforeWrap = '';
 
       el.textContent = '';
-      var elHeight = window.getComputedStyle(el).height;
+      var elStyle = window.getComputedStyle(el);
+      var elHeight = elStyle.height;
 
       var _iteratorNormalCompletion2 = true;
       var _didIteratorError2 = false;
@@ -54,8 +55,8 @@ function ellipsed() {
             el.textContent = '' + el.textContent + token + '...';
           }
 
-          if (parseFloat(window.getComputedStyle(el).height) > parseFloat(elHeight)) {
-            elHeight = window.getComputedStyle(el).height;
+          if (parseFloat(elStyle.height) > parseFloat(elHeight)) {
+            elHeight = elStyle.height;
             rowsWrapped++;
 
             if (rowsWrapped === rows + 1) {

diff --git a/src/ellipsed.js b/src/ellipsed.js
@@ -26,7 +26,8 @@ function ellipsed(selector = '', rows = 1) {
     let textBeforeWrap = '';
 
     el.textContent = '';
-    let elHeight = window.getComputedStyle(el).height;
+    const elStyle = window.getComputedStyle(el);
+    let elHeight = elStyle.height;
 
     for (const token of splittedText) {
       if (el.textContent.length) {
@@ -35,8 +36,8 @@ function ellipsed(selector = '', rows = 1) {
         el.textContent = `${el.textContent}${token}...`;
       }
 
-      if (parseFloat(window.getComputedStyle(el).height) > parseFloat(elHeight)) {
-        elHeight = window.getComputedStyle(el).height;
+      if (parseFloat(elStyle.height) > parseFloat(elHeight)) {
+        elHeight = elStyle.height;
         rowsWrapped++;
 
         if (rowsWrapped === rows + 1) {