New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed for..of for browser compatibility #12

Merged

nzambello merged 3 commits into nzambello:master from pnicolli:pnicolli_functions

Sep 21, 2017

Contributor

pnicolli commented Sep 20, 2017

The use of for..of was giving trouble with browser compatibility. Instead of trying to add babel-polyfill for just a simple loop, I switched to:

a good old for(;;) to loop over the NodeList returned by document.querySelectorAll()
a call to reduce to operate on the string tokens that are part of the string to ellipsize.

Fixes #6

pnicolli added 3 commits

September 18, 2017 19:32


          wip: functions instead of for

8516b7e


          WIP: functions

f88b9c8


          Removed for..of for browser compatibility

nzambello merged commit 150a236 into nzambello:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet