Get file extension based on content-type application/javascript #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benib
approved these changes
Sep 12, 2018
plugins/file/index.js
Outdated
| @@ -87,7 +87,15 @@ module.exports = { | |||
| return Boom.unsupportedMediaType("Content-type not allowed"); | |||
| } | |||
|
|
|||
| const type = mimos.type(contentType); | |||
| // The mimos package doesn't store the extension for the content-type text/javascript | |||
| // because its marked as depricated by IANA. Therefore we get the file extension based | |||
There was a problem hiding this comment.
just a small type: deprecated
There was a problem hiding this comment.
Fixed in 1e2eb46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
text/javascript, because IANA marks this content-type as depricated. See this issue for more details.application/javascript