Release 10.0.0 #199
Merged
Release 10.0.0 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests 49/50 were failing on my machine. ✖ 49) returns the screenshot info with correct cache-control headers without wait ✖ 50) returns the screenshot info with correct cache-control headers for POST request Error for both: Expected 73 to equal specified value: 76.4375
Summary of relevant changes @hapi/joi v16 - Changes in allow() and valid() No longer accepts array arguments. Must pass each value as a separate argument. See hapijs/joi#2037 - Change error in sync validate() result to undefined instead of null when there is no error See hapijs/joi#2036 See hapijs/joi#2037 @hapi/hapi v19 - No joi schema compiler is loaded by default and must be explicitly loaded using server.validator() See hapijs/hapi#4017 See https://hapi.dev/api/?v=19.1.0#-servervalidatorvalidator @hapi/boom v8 - Change new Boom() to new Boom.Boom() See hapijs/boom#253
fuenkchen
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to new major versions of hapi dependencies.
Summary of relevant changes
@hapi/joi v16
allow()andvalid()No longer accepts array arguments. Must pass each value as a separate argument.
See v16.0.0 Release Notes hapijs/joi#2037
validate()result toundefinedinstead ofnullwhen there is no errorSee { result, error } changed to error undefined instead of null hapijs/joi#2036
See v16.0.0 Release Notes hapijs/joi#2037
@hapi/hapi v19
server.validator()See 19.0.0 Release Notes hapijs/hapi#4017
See https://hapi.dev/api/?v=19.1.0#-servervalidatorvalidator
@hapi/boom v8
new Boom()tonew Boom.Boom()See change new Boom() to new Boom.Boom() hapijs/boom#253