Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nightly features #51

Merged
merged 2 commits into from
Dec 14, 2019
Merged

Enable nightly features #51

merged 2 commits into from
Dec 14, 2019

Conversation

daubaris
Copy link
Contributor

Enables warning repetition even if the project was built. Closes #45 and #36.

@o0Ignition0o
Copy link
Owner

Wow this is awesome ! I’m going to have a look at it tonight or tomorrow.
Once this one is landed I will probably publish a new version on crates.io since it’s quite a great achievement and it makes the mvp milestone complete ! 🎉

Copy link
Owner

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great ! A couple of nits, and we're good to go ! 🎉

"clippy-preview",
"-Z",
"unstable-options",
"--no-default-features",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think --no-default-features is supposed to be added only if self.no_default_features

src/linter/clippy.rs Outdated Show resolved Hide resolved
src/linter/clippy.rs Outdated Show resolved Hide resolved
@o0Ignition0o
Copy link
Owner

LGTM :shipit:

@o0Ignition0o o0Ignition0o merged commit 8e860ba into o0Ignition0o:master Dec 14, 2019
@daubaris daubaris deleted the nightly-features branch December 14, 2019 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quick win: enable clippy-preview unstable features behind a flag ?
2 participants