Always call console_error_panic_hook::set_once and remove ad-hoc uses of it
#63
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very nice! It would be good to have an accompanying snarkyjs PR so that we can see this working in CI |
L-as
added a commit
to dcSpark/snarkyjs
that referenced
this pull request
Jun 30, 2023
Notably includes o1-labs/o1js-bindings#63
…es of it The WASM module now exports `console_error_panic_hook_set_once` which is an alias for `console_error_panic_hook::set_once` to be called from the JS side. It is always called when loading the module in the wrapper JS module.
L-as
added a commit
to dcSpark/snarkyjs
that referenced
this pull request
Jun 30, 2023
Notably includes o1-labs/o1js-bindings#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASM module now exports
console_error_panic_hook_set_oncewhich is an alias forconsole_error_panic_hook::set_onceto be called from the JS side. It is always called when loading the module in the wrapper JS module.