explainOther fixes #109
Merged
explainOther fixes #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove _id from possible highlight fields as this can trigger a bug in ES - Fix explainOther to use consistent apiMethod
worleydl
changed the title
epugh
reviewed
Aug 9, 2022
| @@ -43,6 +43,13 @@ angular.module('o19s.splainer-search') | |||
| var hl = { fields: {} }; | |||
|
|
|||
| angular.forEach(fields, function(fieldName) { | |||
| /* | |||
| * ES doesn't like highlighting on _id if the query has been filtered on _id using a terms query. | |||
There was a problem hiding this comment.
Should we open a ticket with ES to get this fixed? Or is this a "works as designed" limitation?
There was a problem hiding this comment.
It smells like a bug to me tho highlighting on the _id field is a bit odd and probably not supported under the hood anyways. In any case, it would be better if it didn't 500 the request, or at least give a more useful message when it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple issues were breaking "Show Only Rated" in quepid. Highlighting on
_idafter a terms match in ES causes a index out of bounds exception. Also, the API method in explainOther needed to have the right case, might make a constants file at some point.No changes required to Quepid other than cutting a new splainer release and bumping it.