Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for multiplicative boosts in Solr #126

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

wrigleyDan
Copy link
Contributor

No description provided.

@wrigleyDan
Copy link
Contributor Author

Included a fix for handling multiplicative boosts in recent Solr versions.

Tests done:

Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to hear from @softwaredoug as well on this.... WHy did we only find this NOW? ;-)

return meOrOnlyChild(new ProductExplain(explJson));
}
else { //fall back to default behavior of detecting 'weight' in descriptions
WeightExplain.prototype = base;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick on indentation ;-)

@epugh epugh merged commit 72367c2 into o19s:main Jul 5, 2023
@epugh epugh linked an issue Jul 5, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queries including multiplicative boosts not explained correctly
2 participants