Adds impression to action enum #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this contribution. I'm going to merge it for the upcoming release. One thought for the future, how do we document these actions to communicate clearer intent? Is that something we do in the spec? Or maybe in our docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds impression as an event type.
The intent of this action (to differentiate from view) is to record an event when an impression of an object is in view (for a given criteria).
In some contexts impression and view may be synonymous (e.g., ad impression / view) however in other contexts this is likely to be different (e.g., an impression of a product tile vs a view of the product page, an impression of a video program).