Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language support for Modelica #1262

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dietmarw
Copy link

Purpose

Adding language support and icon art for Modelica.

Logo Reference

m_ball

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this won't be possible right now because our current tool for language detection doesn't support Modelica. We'd need tokei to support Modelica, and also have a new release featuring that support.

That's the most significant blocking issue currently, though we may eventually switch tools for language detection.

languages.yaml Outdated Show resolved Hide resolved
@dietmarw
Copy link
Author

I noticed the missing tokei support too and have now submitted a PR for that: XAMPPRocky/tokei#1061

@dietmarw
Copy link
Author

@spenserblack Regarding #1152 , is there anything I could already do wrt adding Modelica in case that is resolved before
XAMPPRocky/tokei#1061 ?

@spenserblack
Copy link
Collaborator

Yeah you can make an issue or PR into https://github.com/spenserblack/gengo if you want. What's most important is knowledge, not code, so an issue is sufficient, but PRs are very welcome!
I can't say when we'll switch over from tokei to gengo, but I'm pretty confident that we can at least deploy new languages more rapidly (and also resolve language ambiguity) when we do.

languages.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, contribution LGTM. The only thing that's left is us resolving upstream issues, so I'm approving this.

@dietmarw
Copy link
Author

Upstream has just merged the addition: XAMPPRocky/tokei#1061

@spenserblack
Copy link
Collaborator

We'll need to wait for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants