-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language support for Modelica #1262
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this won't be possible right now because our current tool for language detection doesn't support Modelica. We'd need tokei to support Modelica, and also have a new release featuring that support.
That's the most significant blocking issue currently, though we may eventually switch tools for language detection.
I noticed the missing tokei support too and have now submitted a PR for that: XAMPPRocky/tokei#1061 |
@spenserblack Regarding #1152 , is there anything I could already do wrt adding Modelica in case that is resolved before |
Yeah you can make an issue or PR into https://github.com/spenserblack/gengo if you want. What's most important is knowledge, not code, so an issue is sufficient, but PRs are very welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, contribution LGTM. The only thing that's left is us resolving upstream issues, so I'm approving this.
Upstream has just merged the addition: XAMPPRocky/tokei#1061 |
We'll need to wait for the next release. |
Purpose
Adding language support and icon art for Modelica.
Logo Reference