Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI flag to hide token from repository URL #1319

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Conversation

o2sh
Copy link
Owner

@o2sh o2sh commented Apr 28, 2024

Following #1314 (comment)

This PR introduces a CLI flag to enable the option of hiding the token from the repository URL, making it an opt-in mechanism rather than the default behavior.

CC @jim4067 @asciimoth @t-h2o

@o2sh o2sh requested a review from spenserblack as a code owner April 28, 2024 11:11
@o2sh o2sh requested review from spenserblack and removed request for spenserblack April 28, 2024 11:11
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

But I believe that one big draw of "*fetch" tools is to share info with other people. Given that, I'm not sure that displaying a secret value by default is preferable default behavior TBH.

@o2sh
Copy link
Owner Author

o2sh commented Apr 29, 2024

Yeah, it's a trade-off between security and transparency.

In my opinion, transparency combined with user control is the best option.

Transparency: ensuring users see the raw data without any modifications.
User Control: allowing users to opt-in to hide tokens if they wish, rather than enforcing it by default.

@o2sh o2sh merged commit 8ef64d4 into main Apr 30, 2024
9 checks passed
@o2sh o2sh deleted the feat/hide-token-flag branch May 7, 2024 22:02
@o2sh o2sh added the feat label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants