-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Support for ATS #523
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo looks great!
It looks like you committed a couple of .DS_Store
files. Can those be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition to the macro in language.rs should be formatted with a tab, due to rustfmt. As your editor is probably consistant with the .editorconfig, which enforces spaces, copy-paste will probably be needed, as it was with fortranlegacy.
Maybe adding .DS_Store to .gitignore? I think they were generated when running make build or make install. |
@jake-87 :
Fixed! 😃 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I wonder when there will be a new release of tokei. XAMPPRocky/tokei#840 was merged a long time ago. |
Yeah, tokei's last release is more than a year old 😟 |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Head branch was pushed to by a user without write access
@spenserblack Sorry for not noticing conflict with upstream. Try the CI pipeline again? |
@pykenny no worries. Although the CI will likely still fail right now since tokei hasn't been released with support for ATS yet. Though hopefully gengo will fix that 😉 Anyway, I don't think you have to worry about this PR. You've done all that we could ask a contributor to do to add a new language. it just depends on us fixing upstream issues. |
There's some major update on onefetch, so redo the commit from current main branch for simplicity. |
- "#FF0000" | ||
- "#0000FF" | ||
chip: "#1AC620" | ||
serialization: ATS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
serialization: ATS |
Our serialization is typically lowercase. This populates the available options for the --ascii-language
option. You don't really need to use this option unless you're adding special characters (CSharp
-> c#
) or renaming (Sh
-> shell
).
Purpose
Adding language support and icon art for ATS.
Language support at
tokei
is still undergoing review, and will provide screenshot once it's available.Logo Reference
https://www.cs.bu.edu/~hwxi/atslangweb/MYDATA/theLogo.png
Preview
Related PR/issues:
onefetch
#490