Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secure Static Analysis to Jenkins Pipeline #39

Merged
merged 10 commits into from
Nov 2, 2023

Conversation

brianherrera
Copy link
Contributor

@brianherrera brianherrera commented Nov 2, 2023

This PR adds security scanning to the repo that was outlined in this RFC. AWS rule sets provided by cdk-nag.

CDK-Nag added to both the pipeline and jenkins server stacks and updated GitHub workflow to run checks on each PR.

Also addressed findings discovered by running cdk-nag: vpc flow logs, sns kms keys, and s3 ssl

image

Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
Signed-off-by: Brian Herrera <brianjherrera@gmail.com>
@brianherrera brianherrera requested a review from a team November 2, 2023 22:34
Copy link
Contributor

@amzn-changml amzn-changml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@brianherrera brianherrera merged commit 2873905 into o3de:main Nov 2, 2023
3 checks passed
@brianherrera brianherrera deleted the add-secure-static-analysis branch November 2, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants