Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile and python errors from the export script #477

Merged
merged 2 commits into from
May 7, 2024

Conversation

spham-amzn
Copy link
Contributor

@spham-amzn spham-amzn commented May 7, 2024

Fixes the following build errors when building against the latest o3de development (commit f35b02e8dc78084eae621ff9cea898daa493e553)

In file included from /data/workspace/o3de-multiplayersample/build/tools/External/Gem-f6f5d0f3/Code/CMakeFiles/MultiplayerSample.dir/Unity/unity_0_cxx.cxx:5:
/data/workspace/o3de-multiplayersample/Gem/Code/Source/UserSettings/MultiplayerSampleUserSettings.cpp:264:32: error: no member named 'm_rayTracing' in 'AZ::Render::SSROptions'
                    ssrOptions.m_rayTracing = (reflectionType == SpecularReflections::ScreenSpaceAndRaytracing) ? 
                    ~~~~~~~~~~ ^

Also fixes the following python error during the project export script

 File "/data/workspace/o3de-multiplayersample/ExportScripts/export_mps.py", line 248, in <module>
    export_multiplayer_sample(ctx=o3de_context,
  File "/data/workspace/o3de-multiplayersample/ExportScripts/export_mps.py", line 101, in export_multiplayer_sample
    launcher_type |= exp.LauncherType.HEADLESS
  File "/root/.o3de/Python/packages/python-3.10.13-rev2-linux/python/lib/python3.10/enum.py", line 437, in __getattr__
    raise AttributeError(name) from None
AttributeError: HEADLESS
TypeError: bundle_assets() got an unexpected keyword argument 'selected_platform

Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
@spham-amzn spham-amzn requested review from AMZN-Gene and moudgils May 7, 2024 03:35
Signed-off-by: Steve Pham <82231385+spham-amzn@users.noreply.github.com>
@spham-amzn spham-amzn merged commit 543b23e into o3de:development May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants