Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js 13 - App directory #703

Merged
merged 131 commits into from
Apr 16, 2023
Merged

Next.js 13 - App directory #703

merged 131 commits into from
Apr 16, 2023

Conversation

oBusk
Copy link
Owner

@oBusk oBusk commented Nov 2, 2022

In the (very) long run, I think the new Next.js rouing structure with Server Components could have many benefits to the npm-diff app.

  • Load diff page directly, with loaders for diff and bundlephobia/packagephobia, and show any as soon as we have it.

    Not sure how caching works here? We obviously don't want to re-diff on every load, so we still need that strong caching.

  • Maybe avoid sending diff-viewer to the client completely.

@vercel
Copy link

vercel bot commented Nov 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
npm-diff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2023 1:55pm

@oBusk
Copy link
Owner Author

oBusk commented Nov 2, 2022

Also getting problems with everyones bane of existance, node-gyp.

./node_modules/node-gyp/lib/Find-VisualStudio.cs
Module parse failed: Unexpected token (9:6)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| // This script needs to be compatible with PowerShell v2 to run on Windows 2008R2 and Windows 7.
| 
> using System;
| using System.Text;
| using System.Runtime.InteropServices;

Should try a fresh repo and see if this problem still happens. Maybe open issue

src/app/about/api/page.tsx Fixed Show fixed Hide fixed
src/components/About/About.tsx Fixed Show fixed Hide fixed
src/app/config.tsx Fixed Show fixed Hide fixed
@oBusk
Copy link
Owner Author

oBusk commented Nov 7, 2022

Also getting problems with everyones bane of existance, node-gyp.

./node_modules/node-gyp/lib/Find-VisualStudio.cs
Module parse failed: Unexpected token (9:6)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| // This script needs to be compatible with PowerShell v2 to run on Windows 2008R2 and Windows 7.
| 
> using System;
| using System.Text;
| using System.Runtime.InteropServices;

Should try a fresh repo and see if this problem still happens. Maybe open issue

This was caused by trying to run the props of the about/api page in clientside code. Moved it back to pages and running it on server again fixed it.

@oBusk
Copy link
Owner Author

oBusk commented Nov 8, 2022

📝 Changed routes:

5 deleted routes:

  • /[...parts]
  • /about/api
  • /about
  • /api/[...parts]
  • /

Commit 14d0b76 (https://npm-diff-qn8tq4dgc-obusk.vercel.app).

@oBusk oBusk marked this pull request as ready for review April 16, 2023 13:54
@oBusk oBusk merged commit 00439c4 into main Apr 16, 2023
@oBusk oBusk deleted the app-directory branch April 16, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant