role: hosted_engine_setup: add_host: Use local_vm_ip #277
Conversation
|
@didib LGTM, Can you please just add |
Done. I didn't verify yet. I don't expect problems, but please note that I didn't try to reproduce a complete deploy, and when I tried a trivial test [1], it didn't reproduce - it did work. [1] https://gist.github.com/didib/2b728dcb35d444fd922b30dc4dad8883 |
arachmani
changed the title
|
This fails in CI, still checking. |
Do not rely on adding a line to /etc/hosts, as this seems to not be enough sometimes. Instead, directly tell ansible to use the IP address. Move the tasks adding the engine as a VM later, to where we already have the IP address. Bug-Url: https://bugzilla.redhat.com/1953029
|
Verified with [1]. It failed, but rather late, for an unrelated reason - emailed infra about it [2]. I think this is ready for merging. Can't think of any concrete reason to be hesitant, although this is quite a significant change - to make it work, I had to move importing to later. [1] https://jenkins.ovirt.org/job/ovirt-system-tests_he-basic-suite-master/2049/ |
Do not rely on adding a line to /etc/hosts, as this seems to not be
enough sometimes. Instead, directly tell ansible to use the IP address.
Bug-Url: https://bugzilla.redhat.com/1953029