Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow downstream name for inventory plugin #293

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

AlanCoding
Copy link
Contributor

Testing with the collection from Automation Hub

[WARNING]:  * Failed to parse /runner/inventory/ovirt.yml with auto plugin:
Invalid value "redhat.rhv.ovirt" for configuration option "plugin_type:
inventory plugin: ansible_collections.redhat.rhv.plugins.inventory.ovirt
setting: plugin ", valid values are: ['ovirt']
  File "/usr/lib/python3.8/site-packages/ansible/inventory/manager.py", line 290, in parse_source
    plugin.parse(self._inventory, self._loader, source, cache=cache)
  File "/usr/lib/python3.8/site-packages/ansible/plugins/inventory/auto.py", line 58, in parse
    plugin.parse(inventory, loader, path, cache=cache)
  File "/usr/share/ansible/collections/ansible_collections/redhat/rhv/plugins/inventory/ovirt.py", line 238, in parse
    config = self._read_config_data(path)
  File "/usr/lib/python3.8/site-packages/ansible/plugins/inventory/__init__.py", line 239, in _read_config_data
    self.set_options(direct=config, var_options=self._vars)

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@AlanCoding
Copy link
Contributor Author

ci test please

@mnecas
Copy link
Member

mnecas commented Jun 11, 2021

ci add to whitelist

@mnecas
Copy link
Member

mnecas commented Jun 11, 2021

Please add changelog

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 7a5b972 into oVirt:master Jun 11, 2021
@wenottingham
Copy link

Is there going to be a release of this to galaxy/hub? Pretty please?

@mnecas
Copy link
Member

mnecas commented Jun 17, 2021

Hi, need to merge a few other PRs and will make the release as soon as possible

@mnecas
Copy link
Member

mnecas commented Jun 17, 2021

Released on galaxy

vjuranek pushed a commit to vjuranek/ovirt-ansible-collection that referenced this pull request Jul 28, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants