HE: Filter IP addresses based on 'ipv6_deployment' #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the beginning of HE deployment we set the 'ipv6_deployment' fact based on host's address. This var should be the source of truth for whether to use an IPv4 or IPv6 address for the HE VM. Until now we were simply picking up the first address that was reported by 'virsh' and using this throughout the rest of the process. This PR adds filtering of the reported addresses based on the value of 'ipv6_deployment'. Additionally we're picking the first address to make other usages of 'local_vm_ip' nicer. Signed-off-by: Marcin Sobczyk <msobczyk@redhat.com>
|
/ost he-basic-suite-master el9stream |
| var: local_vm_ip_candidates | ||
| - name: Select first IPv6 address | ||
| ansible.builtin.set_fact: | ||
| local_vm_ip: "{{ local_vm_ip_candidates.stdout_lines | ansible.netcommon.ipv6 | first }}" |
There was a problem hiding this comment.
ansible.netcommon, is this a new collection?
There was a problem hiding this comment.
ah, no, we already depend on it. Thouhg it looks unused until now
|
/ost he-basic-suite-master el8stream |
|
it seems it's broken on el8stream too now |
|
it seems to me that due to the now-functional ipv4 dhcp entry the vm boots with default route on ipv4, which breaks the assumption and route manipulation of he setup |
|
Same problem happens for IPv4-only deployment. Somehow the bootstrap VM enables and gets IPv6 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the beginning of HE deployment we set the 'ipv6_deployment' fact
based on host's address. This var should be the source of truth for
whether to use an IPv4 or IPv6 address for the HE VM.
Until now we were simply picking up the first address that was reported
by 'virsh' and using this throughout the rest of the process.
This PR adds filtering of the reported addresses based on the value of
'ipv6_deployment'. Additionally we're picking the first address to make
other usages of 'local_vm_ip' nicer.
Signed-off-by: Marcin Sobczyk msobczyk@redhat.com