Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hosted_engine_setup: Detect hosted-engine-ha version using /usr/libexec/platform-python #573

Merged
merged 2 commits into from
Aug 7, 2022
Merged

hosted_engine_setup: Detect hosted-engine-ha version using /usr/libexec/platform-python #573

merged 2 commits into from
Aug 7, 2022

Conversation

arachmani
Copy link
Member

Bug-Url: https://bugzilla.redhat.com/2114769
Signed-off-by: Asaf Rachmani arachman@redhat.com

@arachmani arachmani requested a review from mnecas as a code owner August 3, 2022 12:22
@arachmani
Copy link
Member Author

/ost he-basic-suite-master

@arachmani arachmani changed the title hosted_engine_setup: Detect HA version using rpm command hosted_engine_setup: Detect HA version using yum module Aug 4, 2022
@arachmani arachmani requested review from mwperina, kobihk and didib and removed request for kobihk August 4, 2022 06:57
mwperina
mwperina reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more correct to use package facts to get a version of an installed package? For example:
https://github.com/oVirt/ovirt-engine/blob/master/packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts/tasks/host-os.yml#L11
https://github.com/oVirt/ovirt-engine/blob/master/packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts/tasks/host-os.yml#L31

@michalskrivanek
Copy link
Member

or just use /usr/libexec/platform-python

@arachmani
Copy link
Member Author

Wouldn't it be more correct to use package facts to get a version of an installed package? For example: https://github.com/oVirt/ovirt-engine/blob/master/packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts/tasks/host-os.yml#L11 https://github.com/oVirt/ovirt-engine/blob/master/packaging/ansible-runner-service-project/project/roles/ovirt-host-deploy-facts/tasks/host-os.yml#L31

Yes, you are right, I already tried that and the only con is that the log is larger and contains irrelevant data for this task. I change it to use /usr/libexec/platform-python as @michalskrivanek suggested

@arachmani
Copy link
Member Author

/ost he-basic-suite-master

mwperina
mwperina approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@arachmani arachmani changed the title hosted_engine_setup: Detect HA version using yum module hosted_engine_setup: Detect hosted-engine-ha version using /usr/libexec/platform-python Aug 7, 2022
@arachmani arachmani merged commit 7719475 into oVirt:master Aug 7, 2022
@mnecas mnecas mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

@mnecas mnecas Awaiting requested review from mnecas mnecas is a code owner

@didib didib Awaiting requested review from didib

@kobihk kobihk Awaiting requested review from kobihk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arachmani @michalskrivanek @kobihk @mwperina