-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostgreSQL JDBC driver #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @dupondje comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except a typo in spec 'posttgresql' .
I was only a bit surprised that xmvn did not complain about missing parent pom ... perhaps it's already shipped with different package?
EDIT: actually it did complain.
Unable to resolve parent POM org.postgresql:pgjdbc-core-parent:pom:1.1
These 2 parent poms need to be added under %install and above postgresqljdbc:
%mvn_artifact dependencies/org/postgresql/pgjdbc-versions/1.1.6/pgjdbc-versions-1.1.6.pom
%mvn_artifact dependencies/org/postgresql/pgjdbc-core-parent/1.1.6/pgjdbc-core-parent-1.1.6.pom
6d90a2e
to
44002a8
Compare
I have pushed updates (I've made them for the review anyway) |
Adds PostgreSQL JDBC driver due to recent regression by PostgreSQL JDBC drivers > 42.2.10 Bug-Url: https://bugzilla.redhat.com/2077794 Signed-off-by: Martin Perina <mperina@redhat.com>
44002a8
to
9fb7f2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd wait with merging till Monday, we should know if this workaround is needed or we will have better solution |
Closing in favor of oVirt/ovirt-engine#322 and #10 |
Adds PostgreSQL JDBC driver due to recent regression by PostgreSQL JDBC
drivers > 42.2.10
Bug-Url: https://bugzilla.redhat.com/2077794
Signed-off-by: Martin Perina mperina@redhat.com