-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packaging: setup: Fix the call to ok_to_renew_cert #48
Conversation
ok_to_renew_cert now requires two more parameters - "short_life", which tells whether the cert's life should be (relatively) short (e.g. for a web server) or can be long (e.g. for engine<->hosts communications), and "environment", which is used to check the value of CertExpirationWarnPeriodInDays (the "long" life one). Please note, that the use, there, of environment[ENGINE_DB_ENV_KEYS], breaks us if grafana is set up separately from both the engine and dwh. The documentation currently tells to configure grafana either on the engine machine or on the dwh machine (if they are separate), but nothing thus far prevented configuring it on a third machine. This will now break. Change-Id: I274917c7452c42bc3f3f05446677154852f847e1 Signed-off-by: Yedidyah Bar David <didi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/ost |
Maybe worth adding a release note that Grafana on separate machine is now not possible according to this pr, so users can revert this change if they need. |
Grafana on separate machine is broken regardless of current PR, since oVirt/ovirt-engine#486. Working around this is probably possible by copying /etc/ovirt-engine/engine.conf.d/10-setup-database.conf from the engine machine to the grafana machine, probably after changing ENGINE_DB_HOST to the engine (database) machine's name. I didn't try this, nor do I recommend this, unless really needed. |
ok_to_renew_cert now requires two more parameters - "short_life", which
tells whether the cert's life should be (relatively) short (e.g. for a
web server) or can be long (e.g. for engine<->hosts communications), and
"environment", which is used to check the value of
CertExpirationWarnPeriodInDays (the "long" life one).
Please note, that the use, there, of environment[ENGINE_DB_ENV_KEYS],
breaks us if grafana is set up separately from both the engine and dwh.
The documentation currently tells to configure grafana either on the
engine machine or on the dwh machine (if they are separate), but nothing
thus far prevented configuring it on a third machine. This will now
break.
Change-Id: I274917c7452c42bc3f3f05446677154852f847e1
Signed-off-by: Yedidyah Bar David didi@redhat.com