Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix type error in _customization_sso" #56

Merged

Conversation

didib
Copy link
Member

@didib didib commented Sep 8, 2022

This reverts commit 40b2df1.

I think that patch was merged to fix a bug in manual_files, but broke root_ssh. [2] is an alternative, which should make both work.

[2] oVirt/ovirt-engine#645

This reverts commit 40b2df1.

I think that patch was merged to fix a bug in manual_files, but broke
root_ssh. [2] is an alternative, which should make both work.

[2] oVirt/ovirt-engine#645
@didib didib requested a review from avlitman as a code owner September 8, 2022 12:38
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina merged commit 2041f2f into oVirt:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants