-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable selinux bool for grafana to postgresql connection. #67
Conversation
@tinez maybe this is the reason? |
@michalskrivanek @tinez |
ah, that's this one. well, cool, we can then drop the workaround. |
/ost |
a9dd50c
to
49bd045
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have a clear picture of the issue, nor do I still remember everything fresh. Some comments inside... Thanks! OK for me to merge as-is if it works for you, but perhaps better address some of my comments, in particular about trying to fail earlier than STAGE_PACKAGES.
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/config/selinux.py
Outdated
Show resolved
Hide resolved
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/config/selinux.py
Outdated
Show resolved
Hide resolved
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/config/selinux.py
Outdated
Show resolved
Hide resolved
3fd1053
to
c7bf39a
Compare
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-grafana-dwh/config/selinux.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me (with a minor comment).
I recommend to do thorough testing, including some of the flows I suggested earlier. Handling such tough cases is much harder when arriving from a real live system... Upgrade flows are often sensitive, and restore flows are always critical - you rely on restore to work after you had problems you already failed to solve otherwise.
For package grafana >= 9.2.10-15 there is patch added for selinux module to allow connection from grafana to local postgresql. This flag enabled now during engine-setup command if version with this flag installed. For old versions of the grafana we do nothing with selinux. For versions between 9.2.10-10 and 9.2.10-14 we ask user to update package version. Signed-off-by: Stanislav Melnichuk <melnichuk.stas@gmail.com>
Good, I made a change about your comment. Yep, I know about testing, I haven't done it yet. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For package grafana >= 9.2.10-15 there is patch added for selinux module to allow connection from grafana to local postgresql. This flag enabled now during engine-setup command.