Add EngineBackupInfo containing last backups #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export a new EngineBackupInfo type containing the last backup timestamps of the different engine components. Signed-off-by: Jasper Berton <jasper.berton@team.blue>
dupondje
approved these changes
Feb 4, 2025
| @@ -0,0 +1,96 @@ | |||
| /* | |||
| Copyright (c) 2016 Red Hat, Inc. | |||
There was a problem hiding this comment.
I think above copyright notice should match the one we set for ovirt-engine:
# Copyright oVirt Authors
|
A too late comment about copyright line :-) can possibly be handled in a separate patch, aligining the whole source here to match oVirt Engine copyright line. |
Yea guess we should create a PR that fixes them all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export a new EngineBackupInfo type containing datetime objects when all the different components were backed up for the last time.