core: skip disk profiles validation on memory disk

When we create the memory or metadata disks they are a result of other
command. These disks are not act as virtual disks. In some cases the
user can have permission to execute these command, but he may not have
the disk profile permission to add those disks.

This patch will skip setting the profile in those cases, allowing a user
to create attach disks for disks that are not a real virtual disks.

Change-Id: Ib04048d652c8d98df84ffccc4babd71730b218dc
Bug-Url: https://bugzilla.redhat.com/1565183
Signed-off-by: Liran Rotenberg <lrotenbe@redhat.com>

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java

@@ -18,6 +18,7 @@
 import org.ovirt.engine.core.common.businessentities.ActionGroup;
 import org.ovirt.engine.core.common.businessentities.aaa.DbUser;
 import org.ovirt.engine.core.common.businessentities.profiles.DiskProfile;
+import org.ovirt.engine.core.common.businessentities.storage.DiskContentType;
 import org.ovirt.engine.core.common.businessentities.storage.DiskImage;
 import org.ovirt.engine.core.common.businessentities.storage.DiskStorageType;
 import org.ovirt.engine.core.common.errors.EngineMessage;
@@ -63,6 +64,9 @@ public ValidationResult setAndValidateDiskProfiles(Map<DiskImage, Guid> map, DbU
                         diskImage.getDiskStorageType(), diskImage.getDiskAlias());
                 continue;
             }
+            if (!shouldSetDiskProfileOnImage(diskImage)) {
+                continue;
+            }
             if (diskImage.getDiskProfileId() == null && storageDomainId != null) {
                 List<DiskProfile> diskProfilesList = storageDiskProfilesMap.get(storageDomainId);
                 if (diskProfilesList == null) {
@@ -149,4 +153,9 @@ private boolean isDiskProfilePermitted(DiskProfile diskProfile,
                         diskProfile.getId(),
                         VdcObjectType.DiskProfile) != null;
     }
+
+    private boolean shouldSetDiskProfileOnImage(DiskImage diskImage) {
+        return !(diskImage.getContentType() == DiskContentType.MEMORY_DUMP_VOLUME
+                || diskImage.getContentType() == DiskContentType.MEMORY_METADATA_VOLUME);
+    }
 }