-
Notifications
You must be signed in to change notification settings - Fork 270
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
core: add a destination Storage Domain ID support in "MoveOrCopyImage…
…GroupParameters" Add a clean and naming-consistent destination Storage Domain ID support in the "MoveOrCopyImageGroupParameters" class. Actually hiding usage of the data member from "StorageDomainParametersBase" superclass and wrapping it's getter & setter by the new ones. 1. Fix naming of the getter from "getTargetStorageDomainId()" to a more consistent "getDestStorageDomainId()" and move it from "LiveMigrateDiskParameters" class to its parent's "MoveOrCopyImageGroupParameters". 2. Add a setter "setDestStorageDomainId()" in the "MoveOrCopyImageGroupParameters" class. 3. Better and consistent names for "MoveOrCopyImageGroupParameters" Constructors. 4. Refactoring code over multiple classes to use the above accessor & mutator. Background: Commands performing actions on 2 Storage Domains (source & destination) use "MoveOrCopyImageGroupParameters" or its subclasses. Until "MoveOrCopyImageGroupParameters" there was only 1 Storage Domain used - the one that the action was performed on. The support for source Storage Domain ID was added in "MoveOrCopyImageGroupParameters", while the already existing (in "StorageDomainParametersBase" superclass) Storage Domain ID was implicitly used as the destination Storage Domain ID. Some additional support to easier reference source & destination Storage Domains was added in "LiveMigrateDiskParameters". Still there were a few issues - a missing clear destination Storage Domain ID setter and also inconsistent naming between the classes. Refactoring the code to add the full and naming-consistent source & destination Storage Domains getters and setters in the "MoveOrCopyImageGroupParameters" class, thus those will be inherited by its subclasses (i.e., "LiveMigrateDiskParameters"). Signed-off-by: Pavel Bar <pbar@redhat.com>
- Loading branch information
Showing
6 changed files
with
49 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.