core: simplify SyncDirectLunsCommand#getPluggedVms

Signed-off-by: Arik Hadas <ahadas@redhat.com>
oVirt · May 21, 2023 · 15392d5 · 15392d5
1 parent 54e1397
commit 15392d5
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommand.java b/...dules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommand.java
@@ -1,6 +1,5 @@
 package org.ovirt.engine.core.bll.storage.pool;
 
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -219,12 +218,7 @@ private boolean updateLunDisksOnGuests(Set<LUNs> lunsToUpdateInDb) {
     }
 
     private List<VM> getPluggedVms(Guid diskId) {
-        List<VM> result = vmDao.getForDisk(diskId, false).get(Boolean.TRUE);
-        // Return an empty list if no plugged VMs found
-        if (result == null) {
-             result = new ArrayList<>();
-        }
-        return result;
+        return vmDao.getForDisk(diskId, false).computeIfAbsent(Boolean.TRUE, b -> Collections.emptyList());
     }
 
     private Stream<Guid> getIdsOfDirectLunsToSync() {