-
Notifications
You must be signed in to change notification settings - Fork 270
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
core: create "MultipleStorageDomainsValidator" depending on the flow
Changing "createMultipleStorageDomainsValidator()" to be protected in the "MoveOrCopyDiskCommand" class and overriding it in its derived "LiveMigrateDiskCommand" class to add also the source Storage Domain ID. Thus no need to check in the parent "MoveOrCopyDiskCommand" class whether it's an LSM flow or not, in order to add also the source Storage Domain ID to be checked by the created "MultipleStorageDomainsValidator". Also removing the redundant "isDomainWithinThresholds()" destination Storage Domain validation from the "LiveMigrateDiskCommand" class, since it is correctly performed by the above "MultipleStorageDomainsValidator" that validates both source & destination Storage Domains from its parent's "MoveOrCopyDiskCommand::validateSpaceRequirements()". Signed-off-by: Pavel Bar <pbar@redhat.com> Bug-Url: https://bugzilla.redhat.com/2116309
- Loading branch information
Showing
4 changed files
with
25 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters