fix ansible lint: no-handler: Tasks that run when changed should like…

…ly be handlers
oVirt · Sep 28, 2022 · 3a9ad25 · 3a9ad25
1 parent b7a4b09
commit 3a9ad25
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/...ging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kernel/tasks/main.yml b/...ging/ansible-runner-service-project/project/roles/ovirt-host-deploy-kernel/tasks/main.yml
@@ -16,11 +16,9 @@
   failed_when: not uuid.stdout
 
 - name: Add boot parameter to kernel parameters
-  ansible.builtin.set_fact:
+  ansible.builtin.set_fact: # noqa no-handler
     host_deploy_kernel_cmdline_new: "boot=UUID={{ uuid.stdout }} {{ host_deploy_kernel_cmdline_new }}"
   when: uuid.changed | bool
-  tags:
-    - skip_ansible_lint # E503
 
 - name: Removing old kernel arguments
   ansible.builtin.command: "grubby --update-kernel=ALL --remove-args '{{ host_deploy_kernel_cmdline_old }}'"

diff --git a/...ible-runner-service-project/project/roles/ovirt-provider-ovn-driver/tasks/unconfigure.yml b/...ible-runner-service-project/project/roles/ovirt-provider-ovn-driver/tasks/unconfigure.yml
@@ -7,7 +7,5 @@
   register: ovn_packages
 
 - name: Unconfigure the OVN chassis
-  ansible.builtin.command: vdsm-tool ovn-unconfigure
+  ansible.builtin.command: vdsm-tool ovn-unconfigure # noqa no-handler
   when: not ovn_packages.changed
-  tags:
-    - skip_ansible_lint # E503