core: produce successful event if backup finished successfully

Even if we were unable to remove the auto-generated snapshot, the backup
will be considered successful. This patch produces the right audit log
entry to indicate the backup did not fail.

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/backup/HybridBackupCommand.java

@@ -237,6 +237,31 @@ private void auditLog(AuditLogType type) {
         auditLogDirector.log(this, type);
     }
 
+    @Override
+    public AuditLogType getAuditLogTypeValue() {
+        VmBackup vmBackup = getParameters().getVmBackup();
+        addCustomValue("VmName", getVm().getName());
+        addCustomValue("backupId", vmBackup.getId().toString());
+        switch (getActionState()) {
+            case EXECUTE:
+                return AuditLogType.VM_BACKUP_STARTED;
+            case END_FAILURE:
+                if (vmBackup.getPhase() == VmBackupPhase.SUCCEEDED) {
+                    return AuditLogType.VM_BACKUP_SUCCEEDED;
+                }
+
+                return AuditLogType.VM_BACKUP_FAILED;
+            case END_SUCCESS:
+                if (!getSucceeded()) {
+                    return AuditLogType.VM_BACKUP_FAILED;
+                }
+                if (vmBackup.getPhase() == VmBackupPhase.SUCCEEDED) {
+                    return AuditLogType.VM_BACKUP_SUCCEEDED;
+                }
+        }
+        return null;
+    }
+
     @Override
     protected void restoreCommandState() {
         Guid backupId = getParameters().getVmBackup().getId();