core: Modify free space validation on destination Storage Domain in L…

…SM flow

Modify destination "StorageDomainValidator" getter to return a
dedicated validator that its "getTotalSizeForClonedDisk()" method
requires the additional 3 chunks (approximately 8 GiB) extra space
on the destination Storage Domain.
This is relevant only in LSM flow for cluster version 4.7 or above.

Signed-off-by: Pavel Bar <pbar@redhat.com>
Bug-Url: https://bugzilla.redhat.com/2116309

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java

@@ -707,7 +707,17 @@ protected boolean isDiskSnapshotNotPluggedToOtherVmsThatAreNotDown(Guid imageId)
     }
 
     protected StorageDomainValidator createStorageDomainValidator(StorageDomain storageDomain) {
-        return new StorageDomainValidator(storageDomain);
+        return new StorageDomainValidator(storageDomain) {
+            @Override
+            protected double getTotalSizeForClonedDisk(DiskImage diskImage) {
+                double basicSize = super.getTotalSizeForClonedDisk(diskImage);
+                // Add additional snapshot overhead (relevant only for Live Storage flow, cluster version 4.7 or above).
+                if (FeatureSupported.isReplicateExtendSupported(getCluster().getCompatibilityVersion())) {
+                    basicSize += ImagesHandler.computeImageInitialSizeInBytes(diskImage.getImage());
+                }
+                return basicSize;
+            }
+        };
     }
 
     @Override

backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java

@@ -159,7 +159,7 @@ private double getTotalSizeForClonedDisks(Collection<DiskImage> diskImages) {
      * currently in the VDSM code.
      *
      * */
-    private double getTotalSizeForClonedDisk(DiskImage diskImage) {
+    protected double getTotalSizeForClonedDisk(DiskImage diskImage) {
         double sizeForDisk = ImagesHandler.getTotalActualSizeOfDisk(diskImage, storageDomain.getStorageStaticData());
 
         if (diskImage.getVolumeFormat() == VolumeFormat.COW) {